[Issue 549] Update JSON-RPC over HTTP error responses to return 200 status code #1426
Conversation
… JsonRpcError Signed-off-by: gabrieledm <gabriele.delmonte90@gmail.com>
…tus code Signed-off-by: gabrieledm <gabriele.delmonte90@gmail.com>
Signed-off-by: gabrieledm <gabriele.delmonte90@gmail.com>
Signed-off-by: gabrieledm <gabriele.delmonte90@gmail.com>
Signed-off-by: gabrieledm <gabriele.delmonte90@gmail.com>
The Web3J library is out of conformance for how JSON-RPC is supposed to behave. Since this PR is to bring Besu into conformance this breakage is unfortunately expected. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
This is a re-spin of #1305, with the disabling of some acceptance tests added in. Re-spun to ensure we can fast-track it into the RC1 build on Thursday. @gabrieledm did all the interesting work. |
|
Also, see issue #1425 reminding us to fix the Acceptance Tests. |
shemnon
changed the title
CHANGELOG.md
Outdated
|
|
||
| Prior versions of Besu would set the HTTP Status 400 Bad Request for JSON-RPC requests that completed in an error, regardless of the kind of error. These responses could include a complete JSON-RPC response with an error field. | ||
|
|
||
| In Besu version 20.10 properly formatted requests that have valid parameters (count and content) that otherwise would result in an error will return a HTTP Status 200 OK a JSON-RPC response with an error field will be returned. For example, requesting an account that does not exist in the chain or a block by hash that Besu does not have will now return HTTP 200 OK responses. Unparsable requests, improperly formatted requests, or requests with invalid parameters will continue to return HTTP 400 Bad Request. |
There was a problem hiding this comment.
Suggestion: In Besu version 20.10, properly formatted requests that have valid parameters (count and content) will return a HTTP Status 200 OK, with an error field if an error occurred. For example, requesting an account that does not exist in the chain, or a block by hash that Besu does not have, will now return HTTP 200 OK responses. Unparsable requests, improperly formatted requests, or requests with invalid parameters will continue to return HTTP 400 Bad Request.
CHANGELOG.md
Outdated
|
|
||
| In Besu version 20.10 properly formatted requests that have valid parameters (count and content) that otherwise would result in an error will return a HTTP Status 200 OK a JSON-RPC response with an error field will be returned. For example, requesting an account that does not exist in the chain or a block by hash that Besu does not have will now return HTTP 200 OK responses. Unparsable requests, improperly formatted requests, or requests with invalid parameters will continue to return HTTP 400 Bad Request. | ||
|
|
||
| This was done to bring us more in line with the behavior of other Ethereum Clients. Some community project, such as Web3J versions prior to 4.6.x, will be providing compatible releases in the near future. |
There was a problem hiding this comment.
Suggestion: This was done to bring us more in line with the behavior of other Ethereum Clients. Some community projects, such as Web3J, will be providing compatible releases in the near future.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
…dm/master Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
PR description
Fixed Issue(s)
Was #1305, Fixes #549
Changelog