Add revert reason to eth_estimateGas RPC call error #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLupashevskyi
force-pushed
the
1207-add-revert-reason-for-estimate-gas
branch
3 times, most recently
from
6558049
to
e061bf0
Compare
shemnon
reviewed
Dec 18, 2020
There was a problem hiding this comment.
This also needs unit tests. Try these two files: https://gist.github.com/shemnon/6f3b58798d3bea1a2b299d59475e9758
Because revert is not a frontier feature you will need to probably put them in with the trace tests ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/trace/specs - create a new directory and add that new directory here -
The ordinary jsonrpc tests are all frontier fork and the test .blocks file is fairly opaque, not sure how to re-genreate it on a different fork.
...src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthEstimateGas.java
Show resolved
Hide resolved
VladLupashevskyi
force-pushed
the
1207-add-revert-reason-for-estimate-gas
branch
from
349eff0
to
61d7428
Compare
Signed-off-by: Vladyslav Lupashevskyi <vlad@lupashevskyi.com>
Signed-off-by: Vladyslav Lupashevskyi <vlad@lupashevskyi.com>
Signed-off-by: Vladyslav Lupashevskyi <vlad@lupashevskyi.com>
VladLupashevskyi
force-pushed
the
1207-add-revert-reason-for-estimate-gas
branch
from
61d7428
to
9eeacd9
Compare
|
@shemnon Thank you for your review and files for tests! Here I prepared tests, but decided not to add them directly to |
shemnon
approved these changes
Dec 18, 2020
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Add revert reason to eth_estimateGas RPC call error Signed-off-by: Vladyslav Lupashevskyi <vlad@lupashevskyi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Here I added revert reason to the
datafield of eth_estimateGas rpc error.The error looks as shown here:
Fixed Issue(s)
fixes #1207
Changelog