Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECIP 1103: Magneto EVM and Protocol Upgrades #411

Merged
merged 4 commits into from
Feb 27, 2021
Merged

ECIP 1103: Magneto EVM and Protocol Upgrades #411

merged 4 commits into from
Feb 27, 2021

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Feb 9, 2021

No description provided.

@q9f q9f added type: std-core ECIPs of the type "Core" - changing the Classic protocol. status:1 draft ECIP is in draft stage an can be assigned ECIP number and merged, but requires community consensus. editor:5 needs-review This contribution needs a careful review. labels Feb 9, 2021
@q9f q9f mentioned this pull request Feb 9, 2021
Closed
@stevanlohja stevanlohja self-requested a review February 10, 2021 05:48
gitr0n1n
gitr0n1n approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@gitr0n1n gitr0n1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gitr0n1n
Copy link
Contributor

@q9f Does Mantis support Berlin upgrades as well? Not sure if they've been pinged. @bpmckenna

@bobsummerwill
Copy link
Member

@gitr0n1n There is not Berlin support in Mantis, no. Unlike the other clients, Mantis is ETC specific, so there is no upstream to pull from.

Also worth knowing is that Berlin is not even activated on ETH Mainnet yet.

@gitr0n1n
Copy link
Contributor

gitr0n1n commented Feb 21, 2021 •
edited

@gitr0n1n There is not Berlin support in Mantis, no. Unlike the other clients, Mantis is ETC specific, so there is no upstream to pull from.

Also worth knowing is that Berlin is not even activated on ETH Mainnet yet.

Let me rephrase. This PR states Besu and Core-Geth clients intend to support Berlin upgrades. Does Mantis also intend to support Berlin EIPs? @bpmckenna

developerkevin
developerkevin approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@developerkevin developerkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@q9f q9f added editor:7 looks-good This contribution is well reviewed and good to be merged. and removed editor:5 needs-review This contribution needs a careful review. labels Feb 27, 2021
@q9f q9f merged commit 381fc5e into master Feb 27, 2021
@q9f q9f deleted the 19-magneto branch February 27, 2021 10:47
ziogaschr added a commit to etclabscore/core-geth that referenced this pull request Apr 29, 2021
@ziogaschr
params: set Magneto activation block numbers for classic|mordor|kotti…
fee515c 
… chains

Based on ethereumclassic/ECIPs#411
@ziogaschr ziogaschr mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developerkevin developerkevin developerkevin approved these changes

@gitr0n1n gitr0n1n gitr0n1n approved these changes

@stevanlohja stevanlohja Awaiting requested review from stevanlohja

Assignees
No one assigned
Labels
editor:7 looks-good This contribution is well reviewed and good to be merged. status:1 draft ECIP is in draft stage an can be assigned ECIP number and merged, but requires community consensus. type: std-core ECIPs of the type "Core" - changing the Classic protocol.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@q9f @gitr0n1n @bobsummerwill @developerkevin